linux-kernel - Re: [PATCH v2 1/1] x86/early_printk: Use _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 11:12:18 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	"H . Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for
 IO

On Sun, 2015-10-11 at 21:18 +0200, Thomas Gleixner wrote:
> Andy,
> 
> On Fri, 9 Oct 2015, Andy Shevchenko wrote:
> >  #ifdef CONFIG_PCI
> >  static void mem32_serial_out(unsigned long addr, int offset, int 
> value)
> >  {
> > -     u32 *vaddr = (u32 *)addr;
> > +     void __iomem *vaddr = (void __iomem *)addr;
> >       /* shift implied by pointer type */
> >       writel(value, vaddr + offset);
> 
> This is broken. Assume vaddr = 0x1000 and offset = 1

Yes, I noticed in reply to myself  
http://www.spinics.net/lists/kernel/msg2094143.html

Tests were okay because platform I have is using 8-bit I/O.

Does it make sense to use the following approach?

 void __iomem *vaddr = (void __iomem *)addr;
 writel(value, vaddr + offset << 2);
 

> 
> ==>  u32 *vaddr = 0x1000;
> ==>  vaddr + offset = 0x1004
> 
> with your change
> 
> ==>  void __iomem *vaddr = 0x1000;
> 
> ==>  vaddr + offset = 0x1001
> 
> This comment is there for a reason:
> >       /* shift implied by pointer type */
> 
> Thanks,
> 
>         tglx

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/