linux-kernel - Re: [RFC] fixmap: change temp variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 11:05:26 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	yalin wang <yalin.wang2010@...il.com>
cc:	arnd@...db.de, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] fixmap: change temp variable name

On Mon, 12 Oct 2015, yalin wang wrote:
> Change temp variable name addr to ____addr,
> so that not conflict with the caller's variable name,
> it will build error if call like this:
> __set_fixmap_offset(idx, addr, flags)

Can't we just use inlines to avoid this kind of crap?

Thanks,

	tglx
 
> Signed-off-by: yalin wang <yalin.wang2010@...il.com>
> ---
>  include/asm-generic/fixmap.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h
> index 1cbb833..91ecaed 100644
> --- a/include/asm-generic/fixmap.h
> +++ b/include/asm-generic/fixmap.h
> @@ -72,10 +72,10 @@ static inline unsigned long virt_to_fix(const unsigned long vaddr)
>  /* Return a pointer with offset calculated */
>  #define __set_fixmap_offset(idx, phys, flags)		      \
>  ({							      \
> -	unsigned long addr;				      \
> +	unsigned long ____addr;				      \
>  	__set_fixmap(idx, phys, flags);			      \
> -	addr = fix_to_virt(idx) + ((phys) & (PAGE_SIZE - 1)); \
> -	addr;						      \
> +	____addr = fix_to_virt(idx) + ((phys) & (PAGE_SIZE - 1)); \
> +	____addr;						      \
>  })
>  
>  #define set_fixmap_offset(idx, phys) \
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arch" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/