linux-kernel - [PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 20:24:58 +0800
From:	Liao Tonglang <liaotonglang@...il.com>
To:	tj@...nel.org, axboe@...com, akpm@...ux-foundation.org,
	jack@...e.cz, hannes@...xchg.org
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Liao Tonglang <liaotonglang@...il.com>
Subject: [PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized

Variables m_thresh and m_dirty in function balance_dirty_pages() may use
uninitialized. GCC throws a warning on it. Fixed by assigned to 0 as
initial value.

Signed-off-by: Liao Tonglang <liaotonglang@...il.com>
---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 0a931cd..288db45 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1534,7 +1534,7 @@ static void balance_dirty_pages(struct address_space *mapping,
 	for (;;) {
 		unsigned long now = jiffies;
 		unsigned long dirty, thresh, bg_thresh;
-		unsigned long m_dirty, m_thresh, m_bg_thresh;
+		unsigned long m_dirty = 0, m_thresh = 0, m_bg_thresh;
 
 		/*
 		 * Unstable writes are a feature of certain networked
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/