linux-kernel - Re: [PATCH] ARM: EXYNOS: Fix double of_node_put() when parsing child power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2015 04:11:02 +0900
From:	Kukjin Kim <kgene@...nel.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
CC:	Kukjin Kim <kgene@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: EXYNOS: Fix double of_node_put() when parsing child
 power domains

On 10/12/15 10:26, Krzysztof Kozlowski wrote:
> On each next iteration of for_each_compatible_node() the reference
> counter for current device node is already decreased by the loop
> iterator. The manual call to of_node_get() is required only on loop
> break which is not happening here.
> 
> The double of_node_get() (with enabled CONFIG_OF_DYNAMIC) lead to
> decreasing the counter below expected, initial value.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Fixes: fe4034a3fad7 ("ARM: EXYNOS: Add missing of_node_put() when parsing power domains")
> ---
>  arch/arm/mach-exynos/pm_domains.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c
> index 4a87e86dec45..7c21760f590f 100644
> --- a/arch/arm/mach-exynos/pm_domains.c
> +++ b/arch/arm/mach-exynos/pm_domains.c
> @@ -200,15 +200,15 @@ no_clk:
>  		args.args_count = 0;
>  		child_domain = of_genpd_get_from_provider(&args);
>  		if (IS_ERR(child_domain))
> -			goto next_pd;
> +			continue;
>  
>  		if (of_parse_phandle_with_args(np, "power-domains",
>  					 "#power-domain-cells", 0, &args) != 0)
> -			goto next_pd;
> +			continue;
>  
>  		parent_domain = of_genpd_get_from_provider(&args);
>  		if (IS_ERR(parent_domain))
> -			goto next_pd;
> +			continue;
>  
>  		if (pm_genpd_add_subdomain(parent_domain, child_domain))
>  			pr_warn("%s failed to add subdomain: %s\n",
> @@ -216,8 +216,6 @@ no_clk:
>  		else
>  			pr_info("%s has as child subdomain: %s.\n",
>  				parent_domain->name, child_domain->name);
> -next_pd:
> -		of_node_put(np);
>  	}
>  
>  	return 0;

Looks good to me, applied.

Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/