linux-kernel - RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE6402865BC19@shsmsx102.ccr.corp.intel.com>
Date:	Wed, 14 Oct 2015 17:44:12 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	"Zheng, Lv" <lv.zheng@...el.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Brown, Len" <len.brown@...el.com>
Subject: RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before
 suspend-to-idle

Hi ,Rafael,

> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> Sent: Tuesday, October 13, 2015 4:20 AM
> To: Chen, Yu C
> Cc: Zheng, Lv; linux-pm@...r.kernel.org; linux-acpi@...r.kernel.org; linux-
> kernel@...r.kernel.org; Zhang, Rui; Wysocki, Rafael J; Brown, Len
> Subject: Re: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before
> suspend-to-idle
> 
> On Friday, October 09, 2015 09:50:21 AM Chen, Yu C wrote:
> > Hi, LV
> >
> > > -----Original Message-----
> > > From: Zheng, Lv
> > > Sent: Friday, October 09, 2015 4:33 PM
> > > To: Chen, Yu C; rjw@...ysocki.net; lenb@...nel.org
> > > Cc: linux-pm@...r.kernel.org; linux-acpi@...r.kernel.org; linux-
> > > kernel@...r.kernel.org; Zhang, Rui
> > > Subject: RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting
> > > before suspend-to-idle
> > >
> > > Hi, Yu
> > >
> > > > From: Chen, Yu C
> > > > Sent: Friday, October 09, 2015 4:20 PM
> > > >
> > > >
> > > >  acpi_status acpi_os_remove_interrupt_handler(u32 irq,
> > > > acpi_osd_handler handler)
> > >
> > > Why don't you rename irq here to gsi to improve the readability?
> > > The false naming and the wrong example written for this function are
> > > probably the root causes of all other bad code.
> > > So if we want to stop people making future mistakes, we need to
> > > cleanup ourselves.
> > >
> > OK, will rewrite in next version.
> 
> It would be good to change the subject of the patch too I think, because it is
> not about wakeup IRQs only any more.
> 
OK, will send another series of patches.

Best Regards,
Yu