linux-kernel - Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2015 14:36:25 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Eric Anholt <eric@...olt.net>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>, Wolfram Sang <wsa@...-dreams.de>,
	alsa-devel@...a-project.org, linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform
 drivers

On Wed, Oct 14, 2015 at 05:44:46PM -0700, Eric Anholt wrote:
> Luis de Bethencourt <luis@...ethencourt.com> writes:
> 
> > These platform drivers have a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> > ---
> >  sound/soc/bcm/bcm2835-i2s.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> > index 03fa1cb..8c435be 100644
> > --- a/sound/soc/bcm/bcm2835-i2s.c
> > +++ b/sound/soc/bcm/bcm2835-i2s.c
> > @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
> >  	{},
> >  };
> >  
> > +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> > +
> >  static struct platform_driver bcm2835_i2s_driver = {
> >  	.probe		= bcm2835_i2s_probe,
> >  	.driver		= {
> > -- 
> 
> It looks like this should go through the asoc tree, but I don't see it
> in there.
> 
> FWIW, it is also:
> 
> Acked-by: Eric Anholt <eric@...olt.net>

Hi Eric,

Should I resend adding somebody from the asoc tree to the CC?

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/