linux-kernel - Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 11:42:54 +0530
From:	Jassi Brar <jaswinder.singh@...aro.org>
To:	Leo Yan <leo.yan@...aro.org>
Cc:	Jassi Brar <jassisinghbrar@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	Devicetree List <devicetree@...r.kernel.org>,
	Bintian Wang <bintian.wang@...wei.com>,
	Yiping Xu <xuyiping@...ilicon.com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Wei Xu <xuwei5@...ilicon.com>,
	Rob Herring <robh+dt@...nel.org>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

On 16 October 2015 at 11:38, Leo Yan <leo.yan@...aro.org> wrote:
> On Fri, Oct 16, 2015 at 11:17:32AM +0530, Jassi Brar wrote:
>> On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan <leo.yan@...aro.org> wrote:
>> > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote:
>> >> On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan <leo.yan@...aro.org> wrote:
>> >>
>> >> > +
>> >> > +#define MBOX_CHAN_MAX                  32
>> >> > +#define MBOX_CHAN_NUM                  2
>> >> > +
>> >> You mean the hardware has 32 channels but this driver can not manage
>> >> more than 2 ?
>> >>
>> >> OR, there are 32 interfaces but only 2 physical 'floating' links, so
>> >> no more than 2 interfaces can be active at any time?
>> >
>> > For the later case.
>> Former is a s/w limitation and latter is h/w limitation. From what you
>> write below, it seems former to be the case.
>
> Sorry, i misunderstood the question. It's a s/w limitation.
>
>> > Mailbox also can be used by other modules, such
>> > like audio hifi; later need add links for them if want to enable
>> > audio. But so far only uses first 2 channels.
>> >
>> You mean every time your platform needs another channel, you'll update
>> the driver? Not sure about that. It should be simpler to assign which
>> ever and as many channels as the client asks via DT.
>
> For hi6220, every channel is fixed to specific purpose;
on different platform the purposes may be different, so ....

> so i can
> register all of them in driver, such like hifi related channels;
> Though i cannot test them currently, but this will avoid extra
> efforts for enabling channels anymore, do you think this is okay?
> Or you prefer to bind with DT?
>
.... DT please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/