linux-kernel - Re: [PATCH] spi: kconfig: When possible, compile drivers with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 08:30:47 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	broonie@...nel.org, linux-spi@...r.kernel.org,
	javier@....samsung.com,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: Re: [PATCH] spi: kconfig: When possible, compile drivers with
 COMPILE_TEST

Hi Luis,

[auto build test WARNING on spi/for-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Luis-de-Bethencourt/spi-kconfig-When-possible-compile-drivers-with-COMPILE_TEST/20151015-014349
config: openrisc-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/spi/spi-davinci.c: In function 'davinci_spi_chipselect':
>> drivers/spi/spi-davinci.c:219:6: warning: 'gpio' may be used uninitialized in this function

vim +/gpio +219 drivers/spi/spi-davinci.c

358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  203  
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  204  	v &= ~bits;
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  205  	iowrite32(v, addr);
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  206  }
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  207  
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  208  /*
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  209   * Interface to control the chip select signal
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  210   */
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  211  static void davinci_spi_chipselect(struct spi_device *spi, int value)
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  212  {
212d4b69 drivers/spi/davinci_spi.c Sekhar Nori       2010-10-11  213  	struct davinci_spi *dspi;
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  214  	struct davinci_spi_platform_data *pdata;
365a7bb3 drivers/spi/spi-davinci.c Murali Karicheri  2014-09-16  215  	struct davinci_spi_config *spicfg = spi->controller_data;
7978b8c3 drivers/spi/davinci_spi.c Brian Niebuhr     2010-08-13  216  	u8 chip_sel = spi->chip_select;
212d4b69 drivers/spi/davinci_spi.c Sekhar Nori       2010-10-11  217  	u16 spidat1 = CS_DEFAULT;
23853973 drivers/spi/davinci_spi.c Brian Niebuhr     2010-08-13  218  	bool gpio_chipsel = false;
a88e34ea drivers/spi/spi-davinci.c Murali Karicheri  2014-08-01 @219  	int gpio;
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  220  
212d4b69 drivers/spi/davinci_spi.c Sekhar Nori       2010-10-11  221  	dspi = spi_master_get_devdata(spi->master);
aae7147d drivers/spi/spi-davinci.c Murali Karicheri  2012-12-11  222  	pdata = &dspi->pdata;
358934a6 drivers/spi/davinci_spi.c Sandeep Paulraj   2009-12-16  223  
c0600140 drivers/spi/spi-davinci.c Grygorii Strashko 2014-08-01  224  	if (spi->cs_gpio >= 0) {
a88e34ea drivers/spi/spi-davinci.c Murali Karicheri  2014-08-01  225  		/* SPI core parse and update master->cs_gpio */
23853973 drivers/spi/davinci_spi.c Brian Niebuhr     2010-08-13  226  		gpio_chipsel = true;
a88e34ea drivers/spi/spi-davinci.c Murali Karicheri  2014-08-01  227  		gpio = spi->cs_gpio;

:::::: The code at line 219 was first introduced by commit
:::::: a88e34ea213e1bdbd9b2dfca1e1e5fa68b9649a0 spi: davinci: add support to configure gpio cs through dt

:::::: TO: Murali Karicheri <m-karicheri2@...com>
:::::: CC: Mark Brown <broonie@...aro.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (35423 bytes)