linux-kernel - Re: futex timeout not working? (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 15:41:25 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Stefan Liebler <stli@...ux.vnet.ibm.com>,
	Preeti U Murthy <preeti@...ux.vnet.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: futex timeout not working? (bisected)

On Fri, Oct 16, 2015 at 02:45:37PM +0200, Thomas Gleixner wrote:
> The only point I found which does not update the sequence count is
> timekeeping_init().
> 
> Does the patch below fix your issue?
> 

Yes, it does. Thanks for looking into this and fixing it!


> 8<--------------------
> 
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 3739ac6aa473..44d2cc0436f4 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -1251,7 +1251,7 @@ void __init timekeeping_init(void)
>  	set_normalized_timespec64(&tmp, -boot.tv_sec, -boot.tv_nsec);
>  	tk_set_wall_to_mono(tk, tmp);
> 
> -	timekeeping_update(tk, TK_MIRROR);
> +	timekeeping_update(tk, TK_MIRROR | TK_CLOCK_WAS_SET);
> 
>  	write_seqcount_end(&tk_core.seq);
>  	raw_spin_unlock_irqrestore(&timekeeper_lock, flags);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/