linux-kernel - Re: [PATCH] libata: add support for NCQ commands for SG interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 12:25:09 +0530
From:	Vinayak Kale <vinayak.kale@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	tj@...nel.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, sumit.g.gupta@...gate.com,
	Vinayak Kale <vinayak.kale@...gate.com>
Subject: Re: [PATCH] libata: add support for NCQ commands for SG interface

On Sun, Oct 18, 2015 at 12:12 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 10/17/2015 3:25 PM, Vinayak Kale wrote:
>
>>>> From: Vinayak Kale <vinayak.kale@...gate.com>
>>>>
>>>> This patch is needed to make NCQ commands with FPDMA protocol value
>>>> (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface.
>>>>
>>>> Signed-off-by: Vinayak Kale <vinayak.kale@...gate.com>
>>>> ---
>>>>    drivers/ata/libata-scsi.c | 10 ++++++++--
>>>>    1 file changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
>>>> index 0d7f0da..5b0a5ab 100644
>>>> --- a/drivers/ata/libata-scsi.c
>>>> +++ b/drivers/ata/libata-scsi.c
>>>
>>>
>>> [...]
>>>>
>>>>
>>>> @@ -2963,7 +2965,7 @@ static unsigned int ata_scsi_pass_thru(struct
>>>> ata_queued_cmd *qc)
>>>>                          tf->hob_lbal = cdb[7];
>>>>                          tf->hob_lbam = cdb[9];
>>>>                          tf->hob_lbah = cdb[11];
>>>> -                       tf->flags |= ATA_TFLAG_LBA48;
>>>> +                       tf->flags |= (ATA_TFLAG_LBA48 | ATA_TFLAG_LBA);
>>>
>>>
>>>
>>>     Parens not needed here.
>>
>> That's quite neat :-) Thanks, will change it in V2.
>
>
>     Looking at this hunk again, it seems an unrelated change.

I added ATA_TFLAG_LBA to tf->flags just to conform with similar piece
of code in libata-core.c.
FPDMA Read/Write commands run smoothly even without this flag.
I wouldn't mind removing this change from current patch if it's deemed
unfit here.

>
> MBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/