linux-kernel - Re: [PATCH] leds: leds-net48xx: Use devm_led_classdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 10:16:28 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>
Cc:	Chris Boot <bootc@...tc.net>, Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: leds-net48xx: Use devm_led_classdev_register

Hi Muhammad,

On 10/17/2015 01:32 AM, Muhammad Falak R Wani wrote:
> Use devm_led_classdev_register instead of led_classdev_register,
> removing the redundant net48xx_led_remove function.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> ---
>   drivers/leds/leds-net48xx.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/leds/leds-net48xx.c b/drivers/leds/leds-net48xx.c
> index ec3a2e8..0d214c2 100644
> --- a/drivers/leds/leds-net48xx.c
> +++ b/drivers/leds/leds-net48xx.c
> @@ -39,18 +39,11 @@ static struct led_classdev net48xx_error_led = {
>
>   static int net48xx_led_probe(struct platform_device *pdev)
>   {
> -	return led_classdev_register(&pdev->dev, &net48xx_error_led);
> -}
> -
> -static int net48xx_led_remove(struct platform_device *pdev)
> -{
> -	led_classdev_unregister(&net48xx_error_led);
> -	return 0;
> +	return devm_led_classdev_register(&pdev->dev, &net48xx_error_led);
>   }
>
>   static struct platform_driver net48xx_led_driver = {
>   	.probe		= net48xx_led_probe,
> -	.remove		= net48xx_led_remove,
>   	.driver		= {
>   		.name		= DRVNAME,
>   	},
>

Applied, thanks.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/