linux-kernel - Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 15:41:44 +0530
From:	Anand Moon <linux.amoon@...il.com>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Alim Akhtar <alim.akhtar@...il.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	Javier Martinez Canillas <javier@....samsung.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

Hi Doug/ Krzysztof ,

On 15 October 2015 at 04:10, Doug Anderson <dianders@...omium.org> wrote:
> Hi,
>
> On Tue, Oct 13, 2015 at 6:06 PM, Alim Akhtar <alim.akhtar@...il.com> wrote:
>> +Doug
>> Hello,
>> AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50
>> and SDR104 modes.
>>
>> [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html
>>
>> What I remember is, one need to set "broken-cd" property also in order
>> to make it work because of the vqmmc and vmmc connection on board. I
>> didn't find the link right now, but you can search on the web, there
>> was a long discussion about handling this.
>> Have not checked it recently, so not sure if this got broken somehow.
>
> Right.  It _shouldn't_ be possible to add "vmmc/vqmmc" supplies to
> your DTS (which you do in patch 2/3) and also to use the "gpc2-2" pin
> for card detect (even if you configure it as a GPIO).  Once you add
> "vmmc/vqmmc" then Linux ought to be turning these regulators off when
> no card is plugged in.  Presumably the "vqmmc" regulator is hooked up
> to the "VDDQ_MMC2".  If you look in the user manual for 5422 you can
> see that "GPC2[2]/SD_2_CDn" has power domain "VDDQ_MMC2".  Thus you
> really shouldn't be using that pin when vqmmc is off.  I think at some
> point someone claimed that it still worked for them, but nobody could
> ever explain why.  Full discussion at
> <https://patchwork.kernel.org/patch/4763881/>
>
> ---
>
> In case it matters, comments on stuff from earlier in the thread:
>
> * As people pointed out, exynos5422 certainly supports all these modes
> (including DDR50) in the SoC.
>
> * Just because the SoC supports these modes doesn't mean that the
> boards do, which is why the SoC .dtsi doesn't include them.  Thus,
> this patch is "right" in that it changes a board-specific file.
>
> * As Krzysztof points out this board doesn't "add" support but rather
> "enables" support.  The distinction is subtle.
>
> * You might be able to get DDR50 working, but probably better to just
> start with SDR modes.  Previously I never attempted to get DDR50 cards
> working, so possibly the software needs extra work?
>

Thanks for clarifying all the background details on the mmc changes.

Here is what I would conclude from the previous mail chain's.

1 Drop the cd-gpios changes. pinctrl-0 changes.

2 Fix the regulator changes for vmmc/vqmmc with disable of regulator-always-on;

3 Drop this UHS-I changes as if now.

Is this ok with you.

-Anand Moon

>
> -Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/