linux-kernel - Re: [PATCH] devfreq: correctly check failed allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 20 Oct 2015 00:49:31 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Insu Yun <wuninsu@...il.com>,
	박경민 <kyungmin.park@...sung.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	"taesoo@...ech.edu" <taesoo@...ech.edu>,
	"yeongjin.jang@...ech.edu" <yeongjin.jang@...ech.edu>,
	"insu@...ech.edu" <insu@...ech.edu>,
	"changwoo@...ech.edu" <changwoo@...ech.edu>
Subject: Re: [PATCH] devfreq: correctly check failed allocation

>Since devm_kzalloc can be failed in memory pressure,
>check return value and handle error.
>
>Signed-off-by: Insu Yun <wuninsu@...il.com>
>---
> drivers/devfreq/devfreq.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>index ca1b362..814089f 100644
>--- a/drivers/devfreq/devfreq.c
>+++ b/drivers/devfreq/devfreq.c
>@@ -482,9 +482,23 @@ struct devfreq *devfreq_add_device(struct device *dev,
> 						devfreq->profile->max_state *
> 						devfreq->profile->max_state,
> 						GFP_KERNEL);
>+	if (!devfreq->trans_table) {
>+		dev_err(dev, "%s: Unable to create transition table for the device\n",
>+			__func__);
>+		err = -ENOMEM;
>+		goto err_dev;
>+	}
>+

I don't see a label 'err_dev' in devfreq.c
And please note that you are under a mutex lock here as well; you must unlock it before returning.


For devfreq.c of most recent release candidate, please refer to 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/devfreq/devfreq.c?id=7379047d5585187d1288486d4627873170d0005a

You don't seem to be based on a recent RC as well.

Cheers,
MyungJoo