linux-kernel - Re: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC

Open Source and information security mailing list archives

Date:	Tue, 20 Oct 2015 18:17:13 +0800
From:	chenfeng <puck.chen@...ilicon.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<mark.rutland@....com>, <dan.zhao@...ilicon.com>,
	<linuxarm@...wei.com>, <joro@...tes.org>,
	<z.liuxinliang@...ilicon.com>, <qijiwen@...ilicon.com>,
	<devicetree@...r.kernel.org>, <weidong2@...ilicon.com>,
	<pawel.moll@....com>, <ijc+devicetree@...lion.org.uk>,
	<suzhuangluan@...ilicon.com>, <robh+dt@...nel.org>,
	<puck.chen@...yun.com>, <yudongbin@...ilicon.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<peter.panshilin@...ilicon.com>, <linux-kernel@...r.kernel.org>,
	<saberlily.xia@...ilicon.com>, <galak@...eaurora.org>
Subject: Re: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC


Thanks for review.
On 2015/10/20 17:00, Arnd Bergmann wrote:
> On Tuesday 20 October 2015 16:45:24 Chen Feng wrote:
>> +
>> +               smmu@...10000 {
> 
> I think the canonical name for an IOMMU device is 'iommu', not 'smmu'.
Accept.
> 
>> +                       compatible = "hisilicon,hi6220-smmu";
>> +                       reg = <0x0 0xf4210000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
>> +                       clocks = <&sys_ctrl HI6220_MMU_CLK>,
>> +                                <&media_ctrl HI6220_MED_MMU>,
>> +                                <&sys_ctrl HI6220_MEDIA_PLL_SRC>;
>> +                       clock-names = "smmu_clk",
>> +                                     "media_sc_clk",
>> +                                     "smmu_peri_clk";
> 
> 
> Better avoid underscores in strings, and drop the "_clk" postfix in
> the clock names.
> 
> I did not receive patch 1/3 this time, but I see in version 1, that
> you forgot to document the strings:
> 
Accept, I will change this.
>> +- clock-names: The name to enable clock with clock framework.
> 
> This needs to list the names of the clock inputs to the smmu.
> 
> 	Arnd
> _______________________________________________
> linuxarm mailing list
> linuxarm@...wei.com
> http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives