linux-kernel - Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Oct 2015 10:46:35 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	"Wangnan (F)" <wangnan0@...wei.com>, linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Borislav Petkov <bp@...e.de>,
	Chandler Carruth <chandlerc@...il.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Stephane Eranian <eranian@...gle.com>,
	pi3orama <pi3orama@....com>
Subject: Re: [PATCH 13/16] perf callchain: Switch default to
 'graph,0.5,caller'

Em Wed, Oct 21, 2015 at 10:43:48AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Oct 21, 2015 at 10:48:16AM +0200, Ingo Molnar escreveu:
> > 5) --no-children
> > 
> > I agree that 'perf top -g --no-children' looks more intuitive than 'perf top -g'.
> 
> So, what do you propose, to switch back the default to --no-children,
> for both tools, top and report? Now that I am getting used to it... ;-)

And for this one, having a hotkey to toggle children/no-children, in
'top', using a big hammer (perhaps the only one possible since we have
no perf.data file?) we could just trow away the existing hist_entries,
and flip the relevant flag, the new samples would then use the new mode,
etc.

For 'report' it would involve, at first sight, reprocessing everything,
possibly saving some work because we already did symbol resolution, etc,
i.e. the struct machine with its threads, etc will be all there.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/