linux-kernel - Re: [PATCH 2/5] mmc: omap_hsmmc: Enable omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Oct 2015 15:32:38 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Franklin S Cooper Jr <fcooper@...com>
Cc:	Santosh Shilimkar <ssantosh@...nel.org>,
	Muralidharan Karicheri <m-karicheri2@...com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Lokesh Vutla <lokeshvutla@...com>
Subject: Re: [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

On 22 October 2015 at 12:58, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Thu, Oct 22, 2015 at 11:28:55AM +0200, Ulf Hansson wrote:
>> On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@...com> wrote:
>> >
>> > From: Lokesh Vutla <lokeshvutla@...com>
>> >
>> > Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
>> > IP found on OMAP platforms.
>> >
>> > Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
>> > ---
>> >  drivers/mmc/host/Kconfig | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> > index 8a1e349..2ccec71 100644
>> > --- a/drivers/mmc/host/Kconfig
>> > +++ b/drivers/mmc/host/Kconfig
>> > @@ -366,7 +366,7 @@ config MMC_OMAP
>> >  config MMC_OMAP_HS
>> >         tristate "TI OMAP High Speed Multimedia Card Interface support"
>> >         depends on HAS_DMA
>> > -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
>> > +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
>>
>> How about:
>> "depends on ARM || COMPILE_TEST"
>
> I'd much prefer the former actually - it's already hard enough to use
> the config tools with the kernel due to the number of silly options
> being presented, there's no need to make it worse.
>
> In fact, I'd like to see more of the former (provided done sensibly)
> to reduce the number of config options seen for configurations to cut
> down on the shere noise of useless options.  For example, if I've
> decided I don't want to support TI OMAP platforms, then I shouldn't
> be offered the TI OMAP MMC driver.

Okay, fair enough and I don't have any strong opinions around this.

I queued up the patch for next, thanks!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/