lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 24 Oct 2015 12:58:20 +0530
From:	Paul Davies C <pauldaviesc@...il.com>
To:	oleg.drokin@...el.com, andreas.dilger@...el.com,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] lustre: obdclass: fix sparse warning

This patch fixes the following warnings given by the sparse:

drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static?
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static?

Signed-off-by: Paul Davies C <pauldaviesc@...il.com>
---
 drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++--
 drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
index 6218ef3..45d92c2 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
@@ -421,7 +421,7 @@ static struct attribute_group lustre_attr_group = {
 	.attrs = lustre_attrs,
 };
 
-int class_procfs_init(void)
+static int class_procfs_init(void)
 {
 	int rc = -ENOMEM;
 	struct dentry *file;
@@ -457,7 +457,7 @@ out:
 	return rc;
 }
 
-int class_procfs_clean(void)
+static int class_procfs_clean(void)
 {
 	if (debugfs_lustre_root != NULL)
 		debugfs_remove_recursive(debugfs_lustre_root);
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index 1515163..6f13f21 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -158,11 +158,11 @@ static struct attribute_group lustre_attr_group = {
 	.attrs = lustre_attrs,
 };
 
-int obd_sysctl_init(void)
+static int obd_sysctl_init(void)
 {
 	return sysfs_create_group(lustre_kobj, &lustre_attr_group);
 }
 
-void obd_sysctl_clean(void)
+static void obd_sysctl_clean(void)
 {
 }
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists