linux-kernel - Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 25 Oct 2015 17:34:27 +0100
From:	Michele Baldessari <michele@...syn.org>
To:	Lars Melin <larsm17@...il.com>
Cc:	Jiri Kosina <jikos@...nel.org>, linux-usb@...r.kernel.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade

On Sun, Oct 25, 2015 at 04:15:17PM +0700, Lars Melin wrote:
> On 2015-10-24 22:44, Michele Baldessari wrote:
> >The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
> >to have the two distinct joysticks working.
> >
> >Before the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >jstest: No such file or directory
> >
> >After the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >
> >Signed-off-by: Michele Baldessari <michele@...syn.org>
> >---
> >  drivers/hid/usbhid/hid-quirks.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> >index 1dff8f0015ba..f69049314a2c 100644
> >--- a/drivers/hid/usbhid/hid-quirks.c
> >+++ b/drivers/hid/usbhid/hid-quirks.c
> >@@ -150,6 +150,7 @@ static const struct hid_blacklist {
> >  	{ USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
> >  	{ USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
> >  	{ USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
> >+	{ USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
> >
> >  	{ 0, 0 }
> >  };
> >
> 
> Sorry but I don't believe that XIN_MO is the owner of the 16c0 VID so should
> not be given that ownership in linux.

The "ownership" of 16c0 is a completely orthogonal issue to this patch.

16c0 was already defined (twice actually):
$ grep -i 0x16c0 drivers/hid/hid-ids.h | awk '{ print $2 }'
USB_VENDOR_ID_ATMEL_V_USB
USB_VENDOR_ID_XIN_MO

cheers,
Michele
-- 
Michele Baldessari            <michele@...syn.org>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/