linux-kernel - Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread

Open Source and information security mailing list archives

Date:	Mon, 26 Oct 2015 10:08:47 -0400
From:	Brian Foster <bfoster@...hat.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Dave Chinner <david@...morbit.com>, Christoph Hellwig <hch@....de>,
	linux-kernel@...r.kernel.org, xfs@....sgi.com
Subject: Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread

On Mon, Oct 26, 2015 at 03:53:40PM +0900, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
> 
> Since xfsaild has been converted to kthread in 0030807c, it calls 
> try_to_freeze() during every AIL push iteration. It however doesn't set 
> itself as freezable, and therefore this try_to_freeze() will never do 
> anything.
> 
> Before (hopefully eventually) kthread freezing gets converted to fileystem 
> freezing, we'd rather mark xfsaild freezable (as it can generate I/O 
> during suspend).
> 
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> ---

Looks fine to me:

Reviewed-by: Brian Foster <bfoster@...hat.com>

>  fs/xfs/xfs_trans_ail.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 1098cf4..06d1a29 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -497,6 +497,7 @@ xfsaild(
>  	long		tout = 0;	/* milliseconds */
>  
>  	current->flags |= PF_MEMALLOC;
> +	set_freezable();
>  
>  	while (!kthread_should_stop()) {
>  		if (tout && tout <= 20)
> -- 
> Jiri Kosina
> SUSE Labs
> 
> _______________________________________________
> xfs mailing list
> xfs@....sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives