linux-kernel - Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Oct 2015 07:22:51 -0500
From:	"Franklin S Cooper Jr." <fcooper@...com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<linux-spi@...r.kernel.org>, Mark Brown <broonie@...nel.org>,
	Sekhar Nori <nsekhar@...com>, <ssantosh@...nel.org>,
	"Ivan T. Ivanov" <iivanov@...sol.com>, <m-karicheri2@...com>,
	"Ivan T. Ivanov" <iivanov.xz@...il.com>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	<hkallweit1@...il.com>
Subject: Re: [PATCH v2] spi: Setup the master controller driver before setting
 the chipselect



On 10/16/2015 10:55 AM, Andy Shevchenko wrote:
> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. <fcooper@...com> wrote:
>>
>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr <fcooper@...com> wrote:
>>>> SPI controllers may need to be properly setup before chip selects
>>>> can be used. Therefore, wait until the spi controller has a chance
>>>> to perform their setup procedure before trying to use the chip
>>>> select.
>>>>
>>>> This also insures that the chip selects pins are in a good
>>>> state before asseting them which otherwise may cause confusion.
>>>>
>>>> Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
>>> Does it mean I have to test it again?
>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included.
> Whatever Mark prefers.
Hi Mark,
I don't see that you pulled this patch into your topic/core branch just yet. Would you prefer
for me to shoot a v3 with Andy's tested by or will you just add it when your ready to
pull it in?

Without this patch several of our boards don't boot in linux-next so if there is anything you
need for me to do please let me know.
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/