linux-kernel - Re: [PATCH] audit: removing unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Oct 2015 15:12:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Paul Moore <paul@...l-moore.com>
Cc:	Saurabh Sengar <saurabh.truth@...il.com>, eparis@...hat.com,
	linux-audit@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: removing unused variable

On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote:
> On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote:
> > variavle rc in not required as it is just used for unchanged for return,
> > and return is always 0 in the function.
[]
> Thanks, applied with some spelling corrections to the description.

As the return value is never actually tested,
it seems better to make it a void function,

> > diff --git a/kernel/audit.c b/kernel/audit.c
[]
> > @@ -686,23 +686,22 @@ static int audit_netlink_ok(struct sk_buff *skb, u16
> > msg_type)
> > 
> >  static int audit_log_common_recv_msg(struct audit_buffer **ab, u16
> > msg_type) {
> > -	int rc = 0;
> >  	uid_t uid = from_kuid(&init_user_ns, current_uid());
> >  	pid_t pid = task_tgid_nr(current);
> > 
> >  	if (!audit_enabled && msg_type != AUDIT_USER_AVC) {
> >  		*ab = NULL;
> > -		return rc;
> > +		return 0;
> >  	}
> > 
> >  	*ab = audit_log_start(NULL, GFP_KERNEL, msg_type);
> >  	if (unlikely(!*ab))
> > -		return rc;
> > +		return 0;
> >  	audit_log_format(*ab, "pid=%d uid=%u", pid, uid);
> >  	audit_log_session_info(*ab);
> >  	audit_log_task_context(*ab);
> > 
> > -	return rc;
> > +	return 0;
> >  }
> > 
> >  int is_audit_feature_set(int i)
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/