linux-kernel - Re: [PATCH 07/10] merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Oct 2015 16:00:45 +0900
From:	Darren Hart <dvhart@...radead.org>
To:	Olof Johansson <olof@...om.net>
Cc:	Michal Marek <mmarek@...e.com>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, dvhart@...ux.intel.com
Subject: Re: [PATCH 07/10] merge_config.sh: add tests

On Wed, Oct 28, 2015 at 09:42:08AM +0900, Olof Johansson wrote:
> For being a small script, merge_config.sh is fairly scary to change since there's no
> real way to know if you did something wrong. So it seems appropriate to add a simple
> test suite.
> 
> I've started with testcases in the areas I care about, other should of course feel
> free to expand on this.
> 
> Use is simple, from the kernel tree, run ./scripts/kconfig/merge_config_test/runall.
> It'll execute out of a tmpdir under /tmp.
> 
> Signed-off-by: Olof Johansson <olof@...om.net>

Thanks for writing the test cases. Shell scripting is so easy to bikeshed - so
I'm going to skip that. I didn't catch any bashisms, and the test coverage is
good.

Reviewed-by: Darren Hart <dvhart@...ux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/