linux-kernel - Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Oct 2015 11:23:51 -0700
From:	Joe Perches <joe@...ches.com>
To:	Bogicevic Sasa <brutallesale@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match
 open parenthesis

On Wed, 2015-10-28 at 19:13 +0100, Bogicevic Sasa wrote:
> This fixes all Alignment should match open parenthesis
> messages from checkpatch.pl

What you suggest is not at all generally accepted kernel style.

> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
[]
> @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
>  		return -ENOMEM;
>  	skb_reserve(skb_out, NET_IP_ALIGN);
>  
> -	memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
> +	memcpy(
> +		skb_put(skb_out, mac_header_len), mac_header_data,
>  		mac_header_len);

What's desired here is:

	memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
	       mac_header_len);

Second line should be:
[tab][7 spaces]mac_header_len);

etc...

btw: Please run your _patches_ through checkpatch.pl, not just
use it to find style issues in files.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/