linux-kernel - Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Oct 2015 09:59:49 +0800
From:	Weidong Wang <wangweidong1@...wei.com>
To:	Joe Perches <joe@...ches.com>
CC:	<kashyap.desai@...gotech.com>, <sumit.saxena@...gotech.com>,
	<uday.lingala@...gotech.com>, <JBottomley@...n.com>,
	<megaraidlinux.pdl@...gotech.com>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level>

On 2015/10/28 3:35, Joe Perches wrote:
> On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote:
>> Reduce object size a little by using dev_<level>
>> calls instead of dev_printk(KERN_<LEVEL>.
> 
> This is also not the same output.
> 
> dev_printk(KERN_DEBUG vs dev_dbg has the same
> behavior as printk(KERN_DEBUG vs pr_debug
> 

yep, You are right.

As Kashyap said, these two patches(Covert [dev_]printk to [dev|pr]_<level>) may
introduced conflicts to their working for megaraid_sas.
So just ignore these two patches.

Regards,
Weidong

>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> []
>> @@ -1884,7 +1884,7 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
>>  	cmd = megasas_get_cmd(instance);
>>  
>>  	if (!cmd) {
>> -		dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:"
>> +		dev_dbg(&instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:"
>>  		       "Failed to get cmd for scsi%d\n",
>>  			instance->host->host_no);
>>  		return -ENOMEM;
> []
>> @@ -5243,7 +5243,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
>>  					     &instance->consumer_h);
>>  
>>  		if (!instance->producer || !instance->consumer) {
>> -			dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
>> +			dev_dbg(&pdev->dev, "Failed to allocate"
>>  			       "memory for producer, consumer\n");
> 
> Note the lack of a space between coalesced string segment words.
> That's one of the reasons to coalesce them.
> 
> 
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/