linux-kernel - Re: [PATCH v13 2/5] gennvm: Generic NVM manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Oct 2015 16:34:55 +0900
From:	Jens Axboe <axboe@...nel.dk>
To:	Dongsheng Yang <yangds.fnst@...fujitsu.com>,
	Matias Bjørling <m@...rling.me>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-nvme@...ts.infradead.org
Cc:	hch@...radead.org, jg@...htnvm.io, Stephen.Bates@...s.com,
	keith.busch@...el.com
Subject: Re: [PATCH v13 2/5] gennvm: Generic NVM manager

On 10/29/2015 08:41 AM, Dongsheng Yang wrote:
> On 10/28/2015 08:30 AM, Matias Bjørling wrote:
>> The implementation for Open-Channel SSDs is divided into media
> [...]
>> +        lun->reserved_blocks = 2; /* for GC only */
>> +        lun->vlun.id = i;
>> +        lun->vlun.lun_id = i % dev->luns_per_chnl;
>> +        lun->vlun.chnl_id = i / dev->luns_per_chnl;
>
> Please use do_div(). % would be not supported in some platforms, as
> the kbuild pointed in V12.

Neither of those are 64-bit variables, which is where you end up with 
the problem on 32-bit archs.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/