linux-kernel - Re: [PATCH 5/7] clocksource/drivers/pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Nov 2015 13:14:29 +0530
From:	Amit Kucheria <amit.kucheria@...durent.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	"moderated list:ARM PORT" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 5/7] clocksource/drivers/pxa_timer: Move the Kconfig rule

On Fri, Oct 30, 2015 at 4:22 AM, Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
> Instead of having the clocksource's Kconfig depending on the arch, let the
> arch to select the timer it needs.

Is this the prescribed way to do things nowadays? It leads to more
options showing up in 'make menuconfig'. Why do I need to see
CLKSRC_PXA if I'm not even compiling for ARCH_PXA (and not interesting
in COMPILE_TEST)?

> The CLKSRC_OF dependency is removed because already selected by the ARCH_PXA,
> and it is added for SA1100.

This bit makes sense.

> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  arch/arm/Kconfig            | 3 +++
>  drivers/clocksource/Kconfig | 3 +--
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 72ad724..aa32286 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -609,6 +609,7 @@ config ARCH_PXA
>         select AUTO_ZRELADDR
>         select COMMON_CLK
>         select CLKDEV_LOOKUP
> +       select CLKSRC_PXA
>         select CLKSRC_MMIO
>         select CLKSRC_OF
>         select GENERIC_CLOCKEVENTS
> @@ -669,6 +670,8 @@ config ARCH_SA1100
>         select ARCH_SPARSEMEM_ENABLE
>         select CLKDEV_LOOKUP
>         select CLKSRC_MMIO
> +       select CLKSRC_PXA
> +       select CLKSRC_OF if OF
>         select CPU_FREQ
>         select CPU_SA1100
>         select GENERIC_CLOCKEVENTS
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 5cd000c..425abbd 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -289,8 +289,7 @@ config CLKSRC_TANGO_XTAL
>         select CLKSRC_OF
>
>  config CLKSRC_PXA
> -       def_bool y if ARCH_PXA || ARCH_SA1100
> -       select CLKSRC_OF if OF
> +       bool
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/