linux-kernel - Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Nov 2015 17:48:38 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Simmons, James A." <simmonsja@...l.gov>
Cc:	"'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
	James Simmons <jsimmons@...radead.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>
Subject: Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups
 for nidstring.c

Yeah.  That is often the fastest way to fix all the checkpatch warnings.

Checkpatch warnings are pretty mechanical.  Just send like 100 patches
at a time until everything is fixed.  Don't overthink.  Say your patch
breaks the alignment then you have to fix that, but otherwise only fix
one thing at a time.  Sometimes people will ask you to fix something
else on the same line, but just say "I didn't introduce that, but yes I
am planning to fix that in a later patchset since I am following the
one thing per patch rule."

Don't feel shame about sending many small patches.  We pretty much merge
everything.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/