linux-kernel - Re: 答复: [PATCHv2 4.3-rc6] proc: fix convert from oom_score_adj to oom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Nov 2015 12:18:50 -0500
From:	Dave Jones <davej@...emonkey.org.uk>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Michal Hocko <mhocko@...nel.org>,
	Hongjie Fang (方洪杰) 
	<Hongjie.Fang@...eadtrum.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 答复: [PATCHv2 4.3-rc6] proc:
 fix convert from oom_score_adj to oom_adj

On Sat, Oct 31, 2015 at 09:38:31PM -0700, David Rientjes wrote:
 > On Fri, 30 Oct 2015, Michal Hocko wrote:
 > 
 > > > I will hunt for other projects still using the deprecated
 > > > file exclusively. Hopefully there won't be too many of them.
 > > 
 > > It doesn't look that bad afterall:
 > > $ curl -s http://codesearch.debian.net/results/7223e657af3f2ad0/packages.json
 > > {"Packages":["tgt","ggobi","hurd","linux","condor","wine-gecko-2.21","android-platform-frameworks-native","nautilus","procps","wireshark","intel-gpu-tools","iceweasel","icedove","ardour","linux-tools","kde4libs","nss-pam-ldapd","chromium-browser","passenger","archipel-agent-virtualmachine-oomkiller","bleachbit","tilestache","slurm-llnl","ns3","nbd","open-iscsi","mhwaveedit","nilfs-tools","stress-ng","lvm2","gradm2","audit","postgresql-common","zfs-fuse","ocfs2-tools","gimp","advene","lldpad","reniced","pitivi","trinity","petri-foo","rtai","postgresql-9.4","procenv","multipath-tools","percona-toolkit","apparmor","upstart","watchdog","boinc","fusil","util-vserver","booth","geeqie","openssh","oar","android-platform-system-core","kinit","xournal","player","gimp-gap","android-tools"]}
>> 
 > I did the same type of searching and fixing back then for things like 
 > udev, chromium, openssh, etc to convert them to oom_score_adj.  It was 
 > mostly trivial because people either set it to -17 to disable from the oom 
 > killer or to 0 to nullify an oom-disabled process.
 > 
 > I'd love to be able to remove oom_adj.  I'm not sure if we can get to that 
 > point if the instance is that "all userspace" must not write to it and it 
 > would require users to rebuild their binaries.  If we could show that all 
 > the major open source users of oom_adj (there can't be _that_ many that 
 > would be significantly impacted since you needed CAP_SYS_RESOURCE to 
 > reduce it) were converted, maybe Linus would accept it.

FWIW, you can probably remove trinity from that list.
It only uses oom_adj as "don't write to this file if it exists".
It's absense would be silently ignored.  The child processes have
been using oom_score_adj for a long time.

	Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/