linux-kernel - [tip:x86/urgent] x86/setup: Fix recent boot crash on 32-bit SMP machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Nov 2015 02:51:46 -0800
From:	tip-bot for Matt Fleming <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	tglx@...utronix.de, ying.huang@...ux.intel.com, mingo@...nel.org,
	stable@...r.kernel.org, hpa@...or.com, luto@...capital.net,
	matt@...eblueprint.co.uk, linux-kernel@...r.kernel.org,
	lersek@...hat.com, pbonzini@...hat.com, bp@...en8.de
Subject: [tip:x86/urgent] x86/setup:
  Fix recent boot crash on 32-bit SMP machines

Commit-ID:  1c5dac914794f0170e1582d8ffdee52d30e0e4dd
Gitweb:     http://git.kernel.org/tip/1c5dac914794f0170e1582d8ffdee52d30e0e4dd
Author:     Matt Fleming <matt@...eblueprint.co.uk>
AuthorDate: Tue, 3 Nov 2015 13:40:41 +0000
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Wed, 4 Nov 2015 11:48:47 +0100

x86/setup: Fix recent boot crash on 32-bit SMP machines

The LKP test robot reported that the bug fix in commit f5f3497cad8c
("x86/setup: Extend low identity map to cover whole kernel range")
causes CONFIG_X86_32 SMP machines to crash on boot when trying to
bring AP cpus online.

The above commit erroneously copies too many of the PGD entries to the
low memory region of 'identity_page_table', resulting in some of the
kernel mappings for PAGE_OFFSET being trashed because,

  KERNEL_PGD_PTRS > KERNEL_PGD_BOUNDARY

The maximum number of PGD entries we can copy without corrupting the
kernel mapping is KERNEL_PGD_BOUNDARY or pgd_index(PAGE_OFFSET).

Fixes: f5f3497cad8c "x86/setup: Extend low identity map to cover whole kernel range"
Reported-by: Ying Huang <ying.huang@...ux.intel.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>
Cc: Laszlo Ersek <lersek@...hat.com>
Cc: lkp@...org
Cc: Borislav Petkov <bp@...en8.de>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Andy Lutomirski <luto@...capital.net>
Cc: <stable@...r.kernel.org>
Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
Link: http://lkml.kernel.org/r/20151103140354.GA2653@codeblueprint.co.uk
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/x86/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index a3cccbf..2b8cbd6 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1180,7 +1180,7 @@ void __init setup_arch(char **cmdline_p)
 	 */
 	clone_pgd_range(initial_page_table,
 			swapper_pg_dir     + KERNEL_PGD_BOUNDARY,
-			KERNEL_PGD_PTRS);
+			KERNEL_PGD_BOUNDARY);
 #endif
 
 	tboot_probe();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/