linux-kernel - Re: [PATCH] Intel device IDs for PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Nov 2015 15:21:51 -0800
From:	Alexandra Yates <alexandra.yates@...ux.intel.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	ptyser@...-inc.com, Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Intel device IDs for PCH

Hi Andy,

On 11/06/2015 10:44 AM, Andy Shevchenko wrote:
> On Tue, Nov 3, 2015 at 9:25 PM, Alexandra Yates
> <alexandra.yates@...ux.intel.com> wrote:
>> Adding Intel codename Lewisburg platform device IDs for PCH.
>>
>> Signed-off-by: Alexandra Yates <alexandra.yates@...ux.intel.com>
>> ---
>>   drivers/mfd/lpc_ich.c | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
>> index c5a9a08..d9904ac6 100644
>> --- a/drivers/mfd/lpc_ich.c
>> +++ b/drivers/mfd/lpc_ich.c
>> @@ -55,6 +55,7 @@
>>    *     document number TBD : Coleto Creek
>>    *     document number TBD : Wildcat Point-LP
>>    *     document number TBD : 9 Series
>> + *     document number TBD : Lewisburg
>>    */
>>
>>   #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> @@ -219,6 +220,7 @@ enum lpc_chipsets {
>>          LPC_COLETO,     /* Coleto Creek */
>>          LPC_WPT_LP,     /* Wildcat Point-LP */
>>          LPC_BRASWELL,   /* Braswell SoC */
>> +       LPC_LEWISBURG,  /* Lewisburg */
>>          LPC_9S,         /* 9 Series */
>>   };
>>
>> @@ -527,6 +529,10 @@ static struct lpc_ich_info lpc_chipset_info[] = {
>>                  .name = "Braswell SoC",
>>                  .iTCO_version = 3,
>>          },
>> +       [LPC_LEWISBURG] = {
>> +               .name = "Lewisburg",
>> +               .iTCO_version = 2,
>> +       },
>>          [LPC_9S] = {
>>                  .name = "9 Series",
>>                  .iTCO_version = 2,
>> @@ -541,6 +547,15 @@ static struct lpc_ich_info lpc_chipset_info[] = {
>>    */
>>   static const struct pci_device_id lpc_ich_ids[] = {
>>          { PCI_VDEVICE(INTEL, 0x0f1c), LPC_BAYTRAIL},
>> +       { PCI_VDEVICE(INTEL, 0xa242), LPC_LEWISBURG},
>
> If you may notice the IDs are sorted by number.
>
>> +       { PCI_VDEVICE(INTEL, 0xa243), LPC_LEWISBURG},
>> +       { PCI_VDEVICE(INTEL, 0xa1c1), LPC_LEWISBURG},
>> +       { PCI_VDEVICE(INTEL, 0xa1c2), LPC_LEWISBURG},
>> +       { PCI_VDEVICE(INTEL, 0xa1c3), LPC_LEWISBURG},
>> +       { PCI_VDEVICE(INTEL, 0xa1c4), LPC_LEWISBURG},
>> +       { PCI_VDEVICE(INTEL, 0xa1c5), LPC_LEWISBURG},
>> +       { PCI_VDEVICE(INTEL, 0xa1c6), LPC_LEWISBURG},
>> +       { PCI_VDEVICE(INTEL, 0xa1c7), LPC_LEWISBURG},
>>          { PCI_VDEVICE(INTEL, 0x1c41), LPC_CPT},
>>          { PCI_VDEVICE(INTEL, 0x1c42), LPC_CPTD},
>>          { PCI_VDEVICE(INTEL, 0x1c43), LPC_CPTM},
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
>

Thank you for your review.  I changed the order to match the series on 
the list.  And sent V2 of the patch.

-- 
Thank you,
<Alexandra>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/