linux-kernel - Re: [PATCH] UBIFS: Delete unnecessary checks before the function call "iput"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Nov 2015 23:15:33 +0100
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Artem Bityutskiy <dedekind1@...il.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	Julia Lawall <julia.lawall@...6.fr>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] UBIFS: Delete unnecessary checks before the function call "iput"

On Wed, Nov 4, 2015 at 8:10 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 4 Nov 2015 20:00:42 +0100
>
> The iput() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  fs/ubifs/recovery.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index 2a1f0bc..586d593 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -1331,8 +1331,7 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
>         struct size_entry *e, *n;
>
>         rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
> -               if (e->inode)
> -                       iput(e->inode);
> +               iput(e->inode);
>                 kfree(e);
>         }
>
> @@ -1533,8 +1532,7 @@ int ubifs_recover_size(struct ubifs_info *c)
>                                 err = fix_size_in_place(c, e);
>                                 if (err)
>                                         return err;
> -                               if (e->inode)
> -                                       iput(e->inode);
> +                               iput(e->inode);
>                         }
>                 }

Applied!

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/