linux-kernel - Re: [PATCH] mm/mlock.c: drop unneeded initialization in munlock_vma_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Nov 2015 10:27:00 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Alexey Klimov <klimov.linux@...il.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:	akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com,
	emunson@...mai.com
Subject: Re: [PATCH] mm/mlock.c: drop unneeded initialization in
 munlock_vma_pages_range()

On 11/10/2015 01:22 AM, Alexey Klimov wrote:
> Before usage page pointer initialized by NULL is reinitialized by
> follow_page_mask(). Drop useless init of page pointer in the beginning
> of loop.
>
> Signed-off-by: Alexey Klimov <klimov.linux@...il.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>   mm/mlock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index 339d9e0..9cb87cb 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -425,7 +425,7 @@ void munlock_vma_pages_range(struct vm_area_struct *vma,
>   	vma->vm_flags &= VM_LOCKED_CLEAR_MASK;
>
>   	while (start < end) {
> -		struct page *page = NULL;
> +		struct page *page;
>   		unsigned int page_mask;
>   		unsigned long page_increm;
>   		struct pagevec pvec;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/