linux-kernel - Re: [PATCH] comedi: comedi_parport: Fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2015 19:48:19 +0530
From:	Ranjith T <ranjithece24@...il.com>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	gregkh@...uxfoundation.org, hsweeten@...ionengravers.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

Actually my name is Ranjith and father name is Thangavel. So I used to
mention my name as Ranjith T.


Thanks,
Ranjith T

On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott <abbotti@....co.uk> wrote:
> On 11/11/2015 13:44, Ranjith T wrote:
>>
>> Is this patch is fine?.
>>
>> Thanks,
>> Ranjith T.
>
>
> Fine apart from the "Signed-off-by" line.  I'm guessing your last name isn't
> really "T".
>
>
>> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@...il.com> wrote:
>>>
>>> BIT macro is used for defining BIT location instead of
>>> shifting operator - coding style issue
>>>
>>> Signed-off-by: Ranjith T <ranjithece24@...il.com>
>>> ---
>>>   drivers/staging/comedi/drivers/comedi_parport.c |    4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c
>>> b/drivers/staging/comedi/drivers/comedi_parport.c
>>> index 15a4093..1bf8ddc 100644
>>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>>> @@ -75,8 +75,8 @@
>>>   #define PARPORT_DATA_REG       0x00
>>>   #define PARPORT_STATUS_REG     0x01
>>>   #define PARPORT_CTRL_REG       0x02
>>> -#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
>>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>>> +#define PARPORT_CTRL_IRQ_ENA   BIT(4)
>>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>>
>>>   static int parport_data_reg_insn_bits(struct comedi_device *dev,
>>>                                        struct comedi_subdevice *s,
>>> --
>>> 1.7.10.4
>
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/