linux-kernel - Re: [PATCH] comedi: cb_pcidda: Fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Nov 2015 18:02:10 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Ranjith Thangavel <ranjithece24@...il.com>,
	gregkh@...uxfoundation.org
Cc:	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro

On 11/11/15 16:27, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@...il.com>
> ---
>   drivers/staging/comedi/drivers/cb_pcidda.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
> index b00a36a..ccb37d1 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidda.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidda.c
> @@ -51,13 +51,13 @@
>
>   /* DAC registers */
>   #define CB_DDA_DA_CTRL_REG		0x00	   /* D/A Control Register  */
> -#define CB_DDA_DA_CTRL_SU		(1 << 0)   /*  Simultaneous update  */
> -#define CB_DDA_DA_CTRL_EN		(1 << 1)   /*  Enable specified DAC */
> +#define CB_DDA_DA_CTRL_SU		BIT(0)   /*  Simultaneous update  */
> +#define CB_DDA_DA_CTRL_EN		BIT(1)   /*  Enable specified DAC */
>   #define CB_DDA_DA_CTRL_DAC(x)		((x) << 2) /*  Specify DAC channel  */
>   #define CB_DDA_DA_CTRL_RANGE2V5		(0 << 6)   /*  2.5V range           */
>   #define CB_DDA_DA_CTRL_RANGE5V		(2 << 6)   /*  5V range             */
>   #define CB_DDA_DA_CTRL_RANGE10V		(3 << 6)   /*  10V range            */
> -#define CB_DDA_DA_CTRL_UNIP		(1 << 8)   /*  Unipolar range       */
> +#define CB_DDA_DA_CTRL_UNIP		BIT(8)   /*  Unipolar range       */
>
>   #define DACALIBRATION1	4	/*  D/A CALIBRATION REGISTER 1 */
>   /* write bits */
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/