linux-kernel - Re: [PATCH v5 2/7] usb: gadget: f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Nov 2015 09:09:32 +0100
From:	Robert Baldyga <r.baldyga@...sung.com>
To:	"Felipe F. Tonello" <eu@...ipetonello.com>,
	linux-usb@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Clemens Ladisch <clemens@...isch.de>
Subject: Re: [PATCH v5 2/7] usb: gadget: f_midi: remove duplicated code

On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
> This code is duplicated from f_midi_start_ep(midi, f, midi->out_ep).
> 
> Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com>

Reviewed-by: Robert Baldyga <r.baldyga@...sung.com>

> ---
>  drivers/usb/gadget/function/f_midi.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index eeb989d..488111d 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -324,7 +324,6 @@ static int f_midi_start_ep(struct f_midi *midi,
>  static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
>  {
>  	struct f_midi *midi = func_to_midi(f);
> -	struct usb_composite_dev *cdev = f->config->cdev;
>  	unsigned i;
>  	int err;
>  
> @@ -340,24 +339,6 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
>  	if (err)
>  		return err;
>  
> -	usb_ep_disable(midi->out_ep);
> -
> -	err = config_ep_by_speed(midi->gadget, f, midi->out_ep);
> -	if (err) {
> -		ERROR(cdev, "can't configure %s: %d\n",
> -		      midi->out_ep->name, err);
> -		return err;
> -	}
> -
> -	err = usb_ep_enable(midi->out_ep);
> -	if (err) {
> -		ERROR(cdev, "can't start %s: %d\n",
> -		      midi->out_ep->name, err);
> -		return err;
> -	}
> -
> -	midi->out_ep->driver_data = midi;
> -
>  	/* allocate a bunch of read buffers and queue them all at once. */
>  	for (i = 0; i < midi->qlen && err == 0; i++) {
>  		struct usb_request *req =
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/