linux-kernel - Re: [PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Nov 2015 11:24:33 +0100 (CET)
From:	Miroslav Benes <mbenes@...e.cz>
To:	Chris J Arges <chris.j.arges@...onical.com>
cc:	live-patching@...r.kernel.org, jeyu@...hat.com,
	Petr Mladek <pmladek@...e.com>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Seth Jennings <sjenning@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Vojtech Pavlik <vojtech@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4 v5] livepatch: Simplify code for relocated external
 symbols

On Thu, 12 Nov 2015, Chris J Arges wrote:

> From: Petr Mladek <pmladek@...e.com>
> 
> The livepatch module might be linked from several .o files.
> All symbols that need to be shared between these .o files
> should be exported. This is a normal programming practice.
> I do not see any reason to access static symbols between
> these .o files.
> 
> This patch removes the search for the static symbols within
> the livepatch module. It makes it easier to understand
> the meaning of the external flag and klp_find_external_symbol()
> function.
> 
> Signed-off-by: Petr Mladek <pmladek@...e.com>
> Signed-off-by: Chris J Arges <chris.j.arges@...onical.com>

I'd remove this patch from the patch set, because

1. Josh needs to confirm that it is possible for kpatch to live without 
external or that we can modify it. This could postpone this patch set as a 
whole.

2. I think the issue is quite independent of the problem this patch set 
solves.

3. I can even imagine that we could get rid of 'external' in klp_func and 
its special handling completely if kpatch allows.

So let's solve it separately. Does anyone have a different opinion?

Miroslav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/