linux-kernel - Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Nov 2015 17:26:52 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Greg KH <gregkh@...uxfoundation.org>, a.p.zijlstra@...llo.nl,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...hat.com>, Jon Corbet <corbet@....net>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Al Grant <al.grant@....com>,
	Paweł Moll <pawel.moll@....com>,
	linux-doc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	fainelli@...adcom.com, Adrian Hunter <adrian.hunter@...el.com>,
	"Jeremiassen, Tor" <tor@...com>, Mike Leach <mike.leach@....com>,
	Chunyan Zhang <zhang.chunyan@...aro.org>
Subject: Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file

On Friday 13 November 2015 09:17:18 Mathieu Poirier wrote:
> On 11 November 2015 at 15:30, Arnd Bergmann <arnd@...db.de> wrote:
> > On Wednesday 11 November 2015 15:17:52 Mathieu Poirier wrote:
> >> SysFS entries are big enough to justify their own file.
> >> As such moving all sysFS related declarations to a dedicated
> >> location.
> >>
> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> >> ---
> >>  drivers/hwtracing/coresight/Makefile               |    3 +-
> >>  drivers/hwtracing/coresight/coresight-etm.h        |    4 +
> >>  .../hwtracing/coresight/coresight-etm3x-sysfs.c    | 1218 +++++++++++++++++++
> >>  drivers/hwtracing/coresight/coresight-etm3x.c      | 1234 +-------------------
> >>
> >
> > You are adding a lot of interfaces here, make sure that each one is documented
> > in Documentation/ABI/.
> 
> Everything is documented in
> Documentation/ABI/testing/sysfs-bus-coresight-devices-etm3x.
> 
> >
> > Your patch series doesn't add anything here, are you just using an existing
> > ABI?
> 
> That is correct.

Ok, excellent. I failed to see that all the implementations are just moved
from one file to another, should really have read the patch description better.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/