linux-kernel - Re: [PATCH] pstore: add support for 64 Bit address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Nov 2015 15:46:09 -0800
From:	Kees Cook <keescook@...omium.org>
To:	"Wiebe, Wladislav (Nokia - DE/Ulm)" <wladislav.wiebe@...ia.com>
Cc:	"anton@...msg.org" <anton@...msg.org>,
	"ccross@...roid.com" <ccross@...roid.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pstore: add support for 64 Bit address space

On Fri, Nov 13, 2015 at 4:10 AM, Wiebe, Wladislav (Nokia - DE/Ulm)
<wladislav.wiebe@...ia.com> wrote:
> Some architectures has there reserved RAM in 64 Bit address space.
> Therefore converting mem_address module parameter to ullong.
>
> Signed-off-by: Wladislav Wiebe <wladislav.wiebe@...ia.com>

If this works correctly, I have no objection. :)

Acked-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

> ---
>  fs/pstore/ram.c            |    4 ++--
>  include/linux/pstore_ram.h |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 319c3a6..bd9812e 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -55,8 +55,8 @@ static ulong ramoops_pmsg_size = MIN_MEM_SIZE;
>  module_param_named(pmsg_size, ramoops_pmsg_size, ulong, 0400);
>  MODULE_PARM_DESC(pmsg_size, "size of user space message log");
>
> -static ulong mem_address;
> -module_param(mem_address, ulong, 0400);
> +static unsigned long long mem_address;
> +module_param(mem_address, ullong, 0400);
>  MODULE_PARM_DESC(mem_address,
>                 "start of reserved RAM used to store oops/panic logs");
>
> diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h
> index 9c9d6c1..4660aaa 100644
> --- a/include/linux/pstore_ram.h
> +++ b/include/linux/pstore_ram.h
> @@ -76,7 +76,7 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz,
>
>  struct ramoops_platform_data {
>         unsigned long   mem_size;
> -       unsigned long   mem_address;
> +       phys_addr_t     mem_address;
>         unsigned int    mem_type;
>         unsigned long   record_size;
>         unsigned long   console_size;
> --
> 1.7.1
>
> Regards,
> Wladislav Wiebe
>
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/