linux-kernel - Re: [PATCH] Staging: iio: iio_simple_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Nov 2015 17:05:03 +0530
From:	Nizam Haider <nizamhaider786@...il.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Lars-Peter Clausen <lars@...afoo.de>, knaack.h@....de,
	pmeerw@...erw.net, gregkh@...uxfoundation.org,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Nizam Haider <nijamh@...c.in>
Subject: Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments
 area

On Sat, Nov 14, 2015 at 05:21:48PM +0000, Jonathan Cameron wrote:
> On 14/11/15 09:28, Lars-Peter Clausen wrote:
> > On 11/14/2015 03:44 AM, Nizam Haider wrote:
> >> Fix simple typo in comments
> >>
> >> Signed-off-by: Nizam Haider <nijamh@...c.in>
> > 
> > Thanks for the patch.
> > 
> >> ---
> >>  drivers/staging/iio/iio_simple_dummy_buffer.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/iio/iio_simple_dummy_buffer.c b/drivers/staging/iio/iio_simple_dummy_buffer.c
> >> index cf44a6f..c8f889b 100644
> >> --- a/drivers/staging/iio/iio_simple_dummy_buffer.c
> >> +++ b/drivers/staging/iio/iio_simple_dummy_buffer.c
> >> @@ -64,7 +64,7 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p)
> >>  		 * software scans: can be considered to be random access
> >>  		 *   so efficient reading is just a case of minimal bus
> >>  		 *   transactions.
> >> -		 * software culled hardware scans:
> >> +		 * software called hardware scans:
> > 
> > I don't think that's a typo. The non-patched version makes a lot more sense
> > then the patched vesion.
> Yup, that's me using some 'more unusual' English terminology, Perhaps the word
> 'dropped' would be clearer.
> 
> Also, that comment is now a little misleading as it is unusual / undesirable
Yes it is misleading now, non-patched version makes a lot more sense then patched
version.
but because of unusual english, should i use dropped and to send new patch or to just
leave it.
(it would be bit easy to understand in first shot with "dropped".)

Nizam
> to now do this in an individual driver.  The core demux code should take care
> of it.
> 
> Hmm.. I'll make a note to reread the comments in that driver and see if any
> others could do with a refresh.
> 
> Jonathan
> > 
> >>  		 *   occasionally a driver may process the nearest hardware
> >>  		 *   scan to avoid storing elements that are not desired. This
> >>  		 *   is the fiddliest option by far.
> >>
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/