linux-kernel - Re: PM: after suspend/resume the system,can not suspends again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Nov 2015 22:12:59 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Cao Minh Hiep <cm-hiep@...so.co.jp>
Cc:	Nguyen Viet Dung <nv-dung@...so.co.jp>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Linux-SH <linux-sh@...r.kernel.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Sakato Ryusuke <ryusuke.sakato.bx@...esas.com>
Subject: Re: PM: after suspend/resume the system,can not suspends again

On 16 November 2015 at 10:13, Cao Minh Hiep <cm-hiep@...so.co.jp> wrote:
> Dear Ulf Hansson,
>
> I am Hiep from Jinzai Solution (a Japanese Company)
> We have tested PM driver on Rcar-Gen2 (Lager, Koelsch Board) at Linux v4.3.
>
> I would like to contact you because we found a patch that relate to a PM bug
> :
>
> After Suspend/resume system one time, we can not suspend the system again!.
> (I attach the test log file)
>
> The patch is show as below:
> a98f1b7 PM / Domains: Fix validation of latency constraints in genpd
> governor
>
> Tested-by: Harunaga <nx-truong@...so.co.jp>
> Reported-by: Cao Minh Hiep <cm-hiep@...so.co.jp>
>
> This problem disapeared if revert this patch.
> Please review it, when you have time!

Thanks for reporting and bisecting!

I had a look and I believe have found the cause of the problem, though
I will need a few days to post a fix for it.

The problem is actually in genpd's ->runtime_suspend() callback, as it
validates PM QoS latencies even when it's being invoked from the
system PM path.
I will post a fixup to genpd in the next couple of days. I would
appreciate if you could help out in testing it.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/