linux-kernel - Re: [PATCH] Sound: Usb: Misc: ua101: replace le16_to_cpu() with usb_endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Nov 2015 09:04:02 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Clemens Ladisch" <clemens@...isch.de>
Cc:	<alsa-devel@...a-project.org>,
	"Cheah Kok Cheong" <thrust73@...il.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Sound: Usb: Misc: ua101: replace le16_to_cpu() with	usb_endpoint_maxp()

On Sun, 15 Nov 2015 14:54:28 +0100,
Clemens Ladisch wrote:
> 
> Cheah Kok Cheong wrote:
> > Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")
> >
> > And commit 29cc88979a88 ("USB: use usb_endpoint_maxp()
> > instead of le16_to_cpu()")
> 
> These sentences no verb.
> 
> > Patched against
> > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> 
> This does not belong into the commit message.
> 
> > Signed-off-by: Cheah Kok Cheong <thrust73@...il.com>
> 
> Otherwise:
> Acked-by: Clemens Ladisch <clemens@...isch.de>

Applied now with some manual fixes.


thanks,

Takashi


> 
> > ---
> >  sound/usb/misc/ua101.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sound/usb/misc/ua101.c b/sound/usb/misc/ua101.c
> > index 9581089..c19a5dd 100644
> > --- a/sound/usb/misc/ua101.c
> > +++ b/sound/usb/misc/ua101.c
> > @@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua)
> >  		return -ENXIO;
> >  	}
> >  	ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd));
> > -	ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> > +	ua->capture.max_packet_bytes = usb_endpoint_maxp(epd);
> >
> >  	epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc;
> >  	if (!usb_endpoint_is_isoc_out(epd)) {
> > @@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua)
> >  		return -ENXIO;
> >  	}
> >  	ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd));
> > -	ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> > +	ua->playback.max_packet_bytes = usb_endpoint_maxp(epd);
> >  	return 0;
> >  }
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/