linux-kernel - Re: [PATCH v5 06/11] scsi: ufs: add quirk to enable host controller without hce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Nov 2015 09:43:26 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Alim Akhtar <alim.akhtar@...sung.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	JBottomley@...n.com, vinholikatti@...il.com,
	gautam.vivek@...sung.com, essuuj@...il.com,
	devicetree@...r.kernel.org, kishon@...com
Subject: Re: [PATCH v5 06/11] scsi: ufs: add quirk to enable host controller without hce

On Monday 09 November 2015 10:56:22 Alim Akhtar wrote:
> +static int ufshcd_hba_enable(struct ufs_hba *hba)
> +{
> +       int ret;
> +
> +       if (hba->quirks & UFSHCI_QUIRK_BROKEN_HCE) {
> +               ufshcd_set_link_off(hba);
> +               ufshcd_vops_hce_enable_notify(hba, PRE_CHANGE);
> +
> +               /* enable UIC related interrupts */
> +               ufshcd_enable_intr(hba, UFSHCD_UIC_MASK);
> +               ret = ufshcd_dme_reset(hba);
> +               if (!ret) {
> +                       ret = ufshcd_dme_enable(hba);
> +                       if (!ret)
> +                               ufshcd_vops_hce_enable_notify(hba, POST_CHANGE);
> +                       if (ret)
> +                               dev_err(hba->dev,
> +                                       "Host controller enable failed with non-hce\n");
> +               }
> +       } else {
> +               ret = ufshcd_hba_execute_hce(hba);
> +       }
> +
> +       return ret;

quirks are often not the best way to deal with host controller specific
differences. How about using a function pointer for ufshcd_hba_enable()
that can be one or the oither implementation?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/