linux-kernel - Re: [PATCH v2] usb: chipidea: removing of_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Nov 2015 13:58:03 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Saurabh Sengar <saurabh.truth@...il.com>
cc:	mans@...sr.com, Peter.Chen@...escale.com,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Saurabh Sengar <saurabh.truth@...il.com>, kbuild-all@...org
Subject: Re: [PATCH v2] usb: chipidea: removing of_find_property

Please check.  The code, with the blank line on line 692, looks strange.

julia

On Tue, 17 Nov 2015, kbuild test robot wrote:

> CC: kbuild-all@...org
> In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.truth@...il.com>
> TO: Saurabh Sengar <saurabh.truth@...il.com>
> CC: mans@...sr.com, Peter.Chen@...escale.com, gregkh@...uxfoundation.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, Saurabh Sengar <saurabh.truth@...il.com>
> CC: Saurabh Sengar <saurabh.truth@...il.com>
>
> Hi Saurabh,
>
> [auto build test WARNING on peter.chen-usb/ci-for-usb-next]
> [also build test WARNING on v4.4-rc1 next-20151117]
>
> url:    https://github.com/0day-ci/linux/commits/Saurabh-Sengar/usb-chipidea-removing-of_find_property/20151117-194333
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb ci-for-usb-next
> :::::: branch date: 68 minutes ago
> :::::: commit date: 68 minutes ago
>
> >> drivers/usb/chipidea/core.c:693:1-27: code aligned with following code on line 695
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout 4375ac1189e900bbde912d31ec3bb66572c0784a
> vim +693 drivers/usb/chipidea/core.c
>
> 63863b98 Heikki Krogerus   2015-09-21  687  	if (usb_get_maximum_speed(dev) == USB_SPEED_FULL)
> 4f6743d5 Michael Grzeschik 2014-02-19  688  		platdata->flags |= CI_HDRC_FORCE_FULLSPEED;
> 4f6743d5 Michael Grzeschik 2014-02-19  689
> 4375ac11 Saurabh Sengar    2015-11-17  690  	if (!of_property_read_u32(dev->of_node, "phy-clkgate-delay-us",
> 4375ac11 Saurabh Sengar    2015-11-17  691  				     &platdata->phy_clkgate_delay_us))
> 1fbf4628 Fabio Estevam     2015-09-08  692
> df96ed8d Peter Chen        2014-09-22 @693  	platdata->itc_setting = 1;
> 4375ac11 Saurabh Sengar    2015-11-17  694
> df96ed8d Peter Chen        2014-09-22 @695  	ret = of_property_read_u32(dev->of_node, "itc-setting",
> df96ed8d Peter Chen        2014-09-22  696  					&platdata->itc_setting);
> 4375ac11 Saurabh Sengar    2015-11-17  697  	if (ret && ret != -EINVAL) {
> 4375ac11 Saurabh Sengar    2015-11-17  698  		dev_err(dev, "failed to get itc-setting\n");
>
> :::::: The code at line 693 was first introduced by commit
> :::::: df96ed8dced21426c54c7f69cf7513e75280957a usb: chipidea: introduce ITC tuning interface
>
> :::::: TO: Peter Chen <peter.chen@...escale.com>
> :::::: CC: Peter Chen <peter.chen@...escale.com>
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/