linux-kernel - Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Nov 2015 10:08:12 -0800
From:	Moritz Fischer <moritz.fischer@...us.com>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	Alan Tull <atull@...nsource.altera.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}.

Michal,

On Tue, Nov 17, 2015 at 9:53 AM, Michal Simek <michal.simek@...inx.com> wrote:

>> +#ifdef CONFIG_PM
>
> remove this

Will do.
>
>> +static int zynq_fpga_runtime_suspend(struct device *dev)
>
> add __maybe_unused here

Will do.

>> +static int zynq_fpga_runtime_resume(struct device *dev)
>
> and here

Will do.

>> +}
>> +
>> +#endif
>
> and remove this.

Will do.

> Body has nothing specific what it is available only for CONFIG_PM that's
> why it should just work.

You're right. I'll resubmit once other people took another look. Not
high priority ;-)

Cheers,

Moritz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/