| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Nov 2015 11:17:40 +0800 From: Hanjun Guo <hanjun.guo@...aro.org> To: Zhou Wang <wangzhou1@...ilicon.com>, Arnd Bergmann <arnd@...db.de> CC: linux-arm-kernel@...ts.infradead.org, Jisheng Zhang <jszhang@...vell.com>, bhelgaas@...gle.com, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] PCI: hisi: fix deferred probing On 11/13/2015 03:29 PM, Zhou Wang wrote: > On 2015/11/12 20:21, Arnd Bergmann wrote: >> The hisi_pcie_probe function is incorrectly marked as __init, as Kconfig >> tells us: >> >> WARNING: drivers/pci/host/built-in.o(.data+0x7780): Section mismatch in reference from the variable hisi_pcie_driver to the function .init.text:hisi_pcie_probe() >> >> If the probe for this device gets deferred past the point where __init >> functions are removed, or the device is unbound and then reattached to >> the driver, we branch into uninitialized memory, which is bad. >> >> This removes the __init annotation. >> >> Signed-off-by: Arnd Bergmann <arnd@...db.de> >> > > Hi Arnd, > > Many thanks, it looks good to me. so > Acked-by: Zhou Wang <wangzhou1@...ilicon.com> I found this problem too and prepared a patch for it, but I noticed that Arnd already fixed it :) Reviewed-by: Hanjun Guo <hanjun.guo@...aro.org> Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists