linux-kernel - Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Nov 2015 17:13:40 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Kyeongdon Kim <kyeongdon.kim@....com>,
	Andrew Morton <akpm@...ux-foundation.org>, ngupta@...are.org,
	linux-kernel@...r.kernel.org, sergey.senozhatsky@...il.com,
	sergey.senozhatsky.work@...il.com
Subject: Re: [PATCH v2] zram: Prevent page allocation failure during
 zcomp_strm_alloc

On (11/23/15 16:43), Sergey Senozhatsky wrote:
[..]
> agree. we also would want to switch from vzalloc() to
> 	__vmalloc_node_flags(size, NUMA_NO_NODE,
> 			GFP_NOIO | __GFP_HIGHMEM |  __GFP_ZERO)

[..]
> > So, Kyeongdon's patch will remove warning overhead and likely to
> > make zcomp_stram_alloc successful with vmalloc so I want to
> > roll it out first. And let's add a WARN_ON_ONCE to detect of
> > failure and rethink it when we receive such report.

hm... for k{z,m}alloc() it does reduce the warning overhead, but not
for vmalloc() -> warn_alloc_failed() [in theory]. So I guess, I'll
change vmalloc() to

	__vmalloc(XXX,
		GFP_NOIO | __GFP_NOWARN | __GFP_HIGHMEM | __GFP_ZERO,
		PAGE_KERNEL);

/* passing __GFP_NOWARN */.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/