linux-kernel - Re: [PATCH] modpost: don't add a trailing wildcard for OF module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2015 09:07:30 +0100
From:	Sjoerd Simons <sjoerd.simons@...labora.co.uk>
To:	Javier Martinez Canillas <javier@....samsung.com>,
	linux-kernel@...r.kernel.org
Cc:	devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
	Jean Delvare <jdelvare@...e.de>,
	Mark Brown <broonie@...nel.org>,
	Brian Norris <computersforpeace@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] modpost: don't add a trailing wildcard for OF module
 aliases

On Thu, 2015-11-19 at 11:28 -0300, Javier Martinez Canillas wrote:
>  scripts/mod/file2alias.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index 5b96206e9aab..65eaab8b7798 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -125,7 +125,7 @@ do
> {                                                            \
>                  sprintf(str + strlen(str), "*");                \
>  } while(0)
>  
> -/* Always end in a wildcard, for future extension */
> +/* End in a wildcard, for future extension */
>  static inline void add_wildcard(char *str)
>  {
>  	int len = strlen(str);
> @@ -704,7 +704,6 @@ static int do_of_entry (const char *filename,
> void *symval, char *alias)
>  		if (isspace (*tmp))
>  			*tmp = '_';
>  
> -	add_wildcard(alias);
>  	return 1;
>  }
>  ADD_TO_DEVTABLE("of", of_device_id, do_of_entry);

Reviewed-by: Sjoerd Simons <sjoerd.simons@...labora.co.uk>

-- 
Sjoerd Simons
Collabora Ltd.