linux-kernel - Re: [RESEND PATCH] drm: omapdrm: tiler: Remove unneded module alias for tiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2015 12:32:02 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Luis de Bethencourt <luisbg@....samsung.com>,
	<linux-kernel@...r.kernel.org>
CC:	<airlied@...ux.ie>, <laurent.pinchart@...asonboard.com>,
	<grygorii.strashko@...aro.org>, <robdclark@...il.com>,
	<dri-devel@...ts.freedesktop.org>
Subject: Re: [RESEND PATCH] drm: omapdrm: tiler: Remove unneded module alias
 for tiler



On 20/10/15 17:48, Luis de Bethencourt wrote:
> omap_dmm_tiler.c can't be compiled as a module and it is built
> unconditionally as part of omapdrm. Since it can't be used as a module,
> there is no need for it to have an unused MODULE_ALIAS().
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> 
> Hi,
> 
> This is a resend of a patch sent September 24 [0]
> 
> Submitting the removal of MODULE_ALIAS("platform:" DMM_DRIVER_NAME):
> As discussed with Tomi Valkeinen in:
> https://lkml.org/lkml/2015/9/24/379
> 
> Thanks,
> Luis
> 
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 7841970..51554c9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1030,4 +1030,3 @@ struct platform_driver omap_dmm_driver = {
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Andy Gross <andy.gross@...com>");
>  MODULE_DESCRIPTION("OMAP DMM/Tiler Driver");
> -MODULE_ALIAS("platform:" DMM_DRIVER_NAME);
> 

Thanks, applying to my 4.5 branch.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)