linux-kernel - Re: [PATCH] mm/compaction: improve comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2015 16:52:17 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Yaowei Bai <baiyaowei@...s.chinamobile.com>,
	akpm@...ux-foundation.org
Cc:	iamjoonsoo.kim@....com, riel@...hat.com, mina86@...a86.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/compaction: improve comment

On 11/24/2015 09:23 AM, Yaowei Bai wrote:
> Make comment more accurate.

Make changelog more descriptive? :)

> Signed-off-by: Yaowei Bai <baiyaowei@...s.chinamobile.com>
> ---
>   mm/compaction.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index de3e1e7..b3cf915 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1708,7 +1708,9 @@ static void compact_nodes(void)
>   /* The written value is actually unused, all memory is compacted */
>   int sysctl_compact_memory;
>
> -/* This is the entry point for compacting all nodes via /proc/sys/vm */
> +/* This is the entry point for compacting all nodes via
> + * /proc/sys/vm/compact_memory
> + */

Strictly speaking, multi-line comments should have a leading empty line, 
e.g.:

/*
  * This is the entry point ...



>   int sysctl_compaction_handler(struct ctl_table *table, int write,
>   			void __user *buffer, size_t *length, loff_t *ppos)
>   {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/