linux-kernel - Re: [PATCH] staging/android: add TODO to de-stage android sync framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2015 15:32:52 -0200
From:	Gustavo Padovan <gustavo@...ovan.org>
To:	Greg Hackmann <ghackmann@...gle.com>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, daniels@...labora.com,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	Arve Hjønnevåg <arve@...roid.com>,
	Riley Andrews <riandrews@...roid.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Rob Clark <robdclark@...il.com>,
	John Harrison <John.C.Harrison@...el.com>
Subject: Re: [PATCH] staging/android: add TODO to de-stage android sync
 framework

2015-11-24 Greg Hackmann <ghackmann@...gle.com>:

> On 11/23/15 11:41 AM, Gustavo Padovan wrote:
> >+ - remove sw_sync, it is used only for testing/debugging and should not be
> >+upstreamed.
> >+ - port sw_sync testcases to use debugfs somehow
> 
> A quick but important nitpick:
> 
> sw_sync itself is just an in-kernel helper for creating fences, when you
> don't have something like sync timeline primitives baked into your hardware.
> 
> CONFIG_SW_SYNC_USER adds the interface for creating and signaling sw_sync
> objects from userspace.  This is the part that's dangerous and only intended
> for testing, etc.
> 
> AFAIK CONFIG_SW_SYNC_USER is the only part people have been objecting to.
> I'm fine with removing it.  Removing the kernel-facing side of sw_sync would
> be a problem for us, since many drivers use it to create their fences.

Right, I probably misundertood things, I'm okay with removing only
CONFIG_SW_SYNC_USER and if others are okay too I'll just send an updated
patch for the TODO.

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/